Message: Re: Message inlining/embedding bug in SLAC HyperNews 1.11-slac-20 Not Logged In (login)
 Next-in-Thread Next-in-Thread
 Next-in-Forum Next-in-Forum

None Re: Message inlining/embedding bug in SLAC HyperNews 1.11-slac-20 

Forum: Hypernews Development
Re: None Message inlining/embedding bug in SLAC HyperNews 1.11-slac-20 (Peter Elmer)
Date: 15 Sep, 2005
From: Peter Elmer <Peter Elmer>

  Hi,

  I tracked this inling bug down to the fact that I was posting most
things via the web interface in my test setup while most of the postings
to the SLAC HyperNews fora were via the email gateway. The difference 
between the two is in the ,urc files:

    email gateway:

AnnotationType: Message
NodeType: 

    web interface:

AnnotationType: 
NodeType: message 

  I'm not 100ure, but it looks like this was some sort of migration
from one type to another. Anyway, the thing that was turning web postings
into Icons instead of actually showing them was:

sub approved_content_filter {
  my ($msg) = @_;
  return ((!$msg->{NodeType} ||
           $msg->{NodeType} eq 'paragraph' ||
           $msg->{NodeType} eq 'content') &&
          (!$msg->{Approval} ||
           $msg->{Approval} eq 'Approved'));
}

in hnview.pl. For now I've just changed it to:

sub approved_content_filter {
  my ($msg) = @_;
  return ((!$msg->{NodeType} ||
           $msg->{NodeType} eq 'message' ||
           $msg->{NodeType} eq 'paragraph' ||
           $msg->{NodeType} eq 'content') &&
          (!$msg->{Approval} ||
           $msg->{Approval} eq 'Approved'));
}

so that the messages posted via the web interface are properly shown
in inline mode, but I think there is more to understand here.

                                   Pete

On Fri, Aug 26, 2005 at 07:21:45AM +0200, Peter Elmer wrote:
>   It looks like there is a message inlining/embedding bug in SLAC
> HyperNews version 1.11-slac-20 (it was also there in 1.11-slac-19). When
> I pick a particular message and then hit the "inline All" button (to get 
> all of the followups in the same thread displayed on a single page) it does 
> not work.
> 
>   It _looks_ like this works in the installation currently used for
> the SLAC Hypernews itself, e.g.
> 
>    http://hypernews.slac.stanford.edu/HyperNews/hypernews/get/HNDevelop/10.html?inline=-1
> 
> but it doesn't work in 1.11-slac-19/1.11-slac-20.
> 
>   What version is the SLAC HyperNews itself currently running? It claims to 
> be "1.11", but presumably the version number wasn't properly updated as we 
> are now, to indicate the SLAC version. Presumably the bug was introduced 
> sometime between that version and 1.11-slac-19 so perhaps this can help 
> track it down. 
> 
>                                  thanks,
>                                    Pete



-------------------------------------------------------------------------
Peter Elmer     E-mail: Peter.Elmer@cern.ch      Phone: +41 (22) 767-4644
Address: CERN Division PPE, Bat. 32 2C-14, CH-1211 Geneva 23, Switzerland
-------------------------------------------------------------------------

 Add Message Add Message
to: "Re: Message inlining/embedding bug in SLAC HyperNews 1.11-slac-20"

 Subscribe Subscribe

This site runs SLAC HyperNews version 1.11-slac-98, derived from the original HyperNews


[ SLAC HyperNews Home | Search | Feedback ]